diff options
Diffstat (limited to 'Echo/includes/special/SpecialNotifications.php')
| -rw-r--r-- | Echo/includes/special/SpecialNotifications.php | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/Echo/includes/special/SpecialNotifications.php b/Echo/includes/special/SpecialNotifications.php index e6552ee8..aae26e4b 100644 --- a/Echo/includes/special/SpecialNotifications.php +++ b/Echo/includes/special/SpecialNotifications.php @@ -11,6 +11,10 @@ class SpecialNotifications extends SpecialPage { parent::__construct( 'Notifications' ); } + /** + * @param string $par + * @suppress SecurityCheck-DoubleEscaped Different members of $notifArray being conflated + */ public function execute( $par ) { $this->setHeaders(); @@ -124,7 +128,7 @@ class SpecialNotifications extends SpecialPage { $markAllAsReadText = $this->msg( 'echo-mark-all-as-read' )->text(); $markAllAsReadLabelIcon = new EchoOOUI\LabelIconWidget( [ 'label' => $markAllAsReadText, - 'icon' => 'doubleCheck', + 'icon' => 'checkAll', ] ); $markAllAsReadForm = $markReadSpecialPage->getMinimalForm( @@ -159,14 +163,14 @@ class SpecialNotifications extends SpecialPage { $heading->appendContent( $dateTitle ); // Mark all read button - if ( count( $data[ 'unread' ] ) > 0 ) { + if ( $data[ 'unread' ] !== [] ) { // tell the UI to show 'unread' notifications only (instead of 'all') $out->addJsConfigVars( 'wgEchoReadState', 'unread' ); $markReadSectionText = $this->msg( 'echo-specialpage-section-markread' )->text(); $markAsReadLabelIcon = new EchoOOUI\LabelIconWidget( [ 'label' => $markReadSectionText, - 'icon' => 'doubleCheck', + 'icon' => 'checkAll', ] ); // There are unread notices. Add the 'mark section as read' button |