aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormkanat%kerio.com <>2005-04-05 04:52:03 +0000
committermkanat%kerio.com <>2005-04-05 04:52:03 +0000
commitf5f31fc070588c2075dd13a0fbabe8117e3aad76 (patch)
tree4a3bb48995143c84fcb8f222b420814e1c6e8eaf /editcomponents.cgi
parentBug 287483: Sanitycheck screams about "Bad value 0 found in components.initia... (diff)
downloadbugzilla-f5f31fc070588c2075dd13a0fbabe8117e3aad76.tar.gz
bugzilla-f5f31fc070588c2075dd13a0fbabe8117e3aad76.tar.bz2
bugzilla-f5f31fc070588c2075dd13a0fbabe8117e3aad76.zip
Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk
Diffstat (limited to 'editcomponents.cgi')
-rwxr-xr-xeditcomponents.cgi7
1 files changed, 4 insertions, 3 deletions
diff --git a/editcomponents.cgi b/editcomponents.cgi
index a86329d9d..9dd290db3 100755
--- a/editcomponents.cgi
+++ b/editcomponents.cgi
@@ -81,9 +81,10 @@ sub TestComponent ($$)
# does the product/component combination exist?
SendSQL("SELECT components.name
- FROM components, products
- WHERE products.id = components.product_id
- AND products.name = " . SqlQuote($prod) . "
+ FROM components
+ INNER JOIN products
+ ON products.id = components.product_id
+ WHERE products.name = " . SqlQuote($prod) . "
AND components.name = " . SqlQuote($comp));
return FetchOneColumn();
}