New RC, add custom-cflags use, fix dependencies and cleanups

(Portage version: 2.2.0_alpha27/cvs/Linux x86_64)

3 files changed, 77 insertions, 67 deletions

diff --git a/app-office/libreoffice/ChangeLog b/app-office/libreoffice/ChangeLog
index a15f4b6c837e..ff79d6ae54ff 100644
--- a/app-office/libreoffice/ChangeLog
+++ b/app-office/libreoffice/ChangeLog
@@ -1,6 +1,17 @@
 # ChangeLog for app-office/libreoffice
 # Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/app-office/libreoffice/ChangeLog,v 1.22 2011/03/17 13:15:32 suka Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-office/libreoffice/ChangeLog,v 1.23 2011/03/18 19:41:58 suka Exp $
+
+*libreoffice-3.3.2_rc2 (18 Mar 2011)
+
+  18 Mar 2011; Andreas Proschofsky <suka@gentoo.org>
+  -libreoffice-3.3.2_rc1.ebuild, +libreoffice-3.3.2_rc2.ebuild,
+  -files/gentoo-3.3.2_rc1.diff, +files/gentoo-3.3.2_rc2.diff:
+  New release candidate, also brings some further improvements to the ebuild
+  *) Add custom-optimization flag, thanks mostly to geki <h.mth@web.de>
+   bug #355981
+  *) Fixed dependency on cairo, we really want that not to be optional
+  *) Bunch of cleanups
 
   17 Mar 2011; Andreas Proschofsky <suka@gentoo.org> libreoffice-3.3.1.ebuild,
   libreoffice-3.3.2_rc1.ebuild:
diff --git a/app-office/libreoffice/files/gentoo-3.3.2_rc1.diff b/app-office/libreoffice/files/gentoo-3.3.2_rc2.diff
index 2a4b293ea2af..2a4b293ea2af 100644
--- a/app-office/libreoffice/files/gentoo-3.3.2_rc1.diff
+++ b/app-office/libreoffice/files/gentoo-3.3.2_rc2.diff
diff --git a/app-office/libreoffice/libreoffice-3.3.2_rc1.ebuild b/app-office/libreoffice/libreoffice-3.3.2_rc2.ebuild
index fd16452ee383..1e7726c1b326 100644
--- a/app-office/libreoffice/libreoffice-3.3.2_rc1.ebuild
+++ b/app-office/libreoffice/libreoffice-3.3.2_rc2.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2011 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/app-office/libreoffice/libreoffice-3.3.2_rc1.ebuild,v 1.4 2011/03/17 13:15:32 suka Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-office/libreoffice/libreoffice-3.3.2_rc2.ebuild,v 1.1 2011/03/18 19:41:58 suka Exp $
 
 EAPI="3"
 
@@ -14,9 +14,9 @@ PYTHON_USE_WITH="threads"
 
 inherit autotools bash-completion check-reqs db-use eutils fdo-mime flag-o-matic gnome2-utils java-pkg-opt-2 kde4-base multilib pax-utils python toolchain-funcs
 
-IUSE="binfilter cups dbus debug eds gnome gstreamer gtk kde ldap nsplugin odk opengl templates"
+IUSE="binfilter cups -custom-cflags dbus debug eds gnome gstreamer gtk kde ldap nsplugin odk opengl templates"
 
-MY_PV=3.3.2.1
+MY_PV=3.3.2.2
 MY_P="${PN}-build-${MY_PV}"
 PATCHLEVEL=OOO320
 SRC=OOo_${PV}_src
@@ -124,72 +124,71 @@ KEYWORDS="~amd64 ~x86 ~amd64-linux ~x86-linux"
 COMMON_DEPEND="!app-office/libreoffice-bin
 	!app-office/openoffice-bin
 	!app-office/openoffice
-	x11-libs/libXaw
-	x11-libs/libXinerama
-	x11-libs/libXrandr
-	>=dev-lang/perl-5.0
-	>=dev-libs/glib-2.18
+	cups? ( net-print/cups )
 	dbus? ( >=dev-libs/dbus-glib-0.71 )
-	gnome? ( >=x11-libs/gtk+-2.10:2
-		gnome-base/gconf:2
-		>=x11-libs/cairo-1.0.2 )
-	gtk? ( >=x11-libs/gtk+-2.10:2
-		>=x11-libs/cairo-1.0.2 )
 	eds? ( >=gnome-extra/evolution-data-server-1.2 )
+	gnome? ( >=x11-libs/gtk+-2.10:2
+		gnome-base/gconf:2 )
+	gtk? ( >=x11-libs/gtk+-2.10:2 )
 	gstreamer? ( >=media-libs/gstreamer-0.10
 			>=media-libs/gst-plugins-base-0.10 )
 	java? ( >=dev-java/bsh-2.0_beta4
 		dev-java/lucene:2.3
 		dev-java/lucene-analyzers:2.3 )
+	ldap? ( net-nds/openldap )
 	nsplugin? ( net-libs/xulrunner:1.9
 		>=dev-libs/nspr-4.6.6
 		>=dev-libs/nss-3.11-r1 )
 	opengl? ( virtual/opengl )
-	>=net-libs/neon-0.24.7
-	>=dev-libs/openssl-0.9.8g
-	>=media-libs/freetype-2.1.10-r2
-	>=media-libs/fontconfig-2.3.0
-	cups? ( net-print/cups )
-	  dev-libs/redland[ssl]
-	virtual/jpeg
-	media-libs/libpng
 	app-arch/zip
 	app-arch/unzip
 	>=app-text/hunspell-1.1.4-r1
+	>=app-text/poppler-0.12.3-r3[xpdf-headers]
 	dev-libs/expat
+	>=dev-libs/glib-2.18
 	>=dev-libs/icu-4.0
-	>=sys-libs/db-4.3
+	>=dev-lang/perl-5.0
+	>=net-libs/neon-0.24.7
+	>=dev-libs/openssl-0.9.8g
+	dev-libs/redland[ssl]
+	>=media-libs/freetype-2.1.10-r2
+	>=media-libs/fontconfig-2.3.0
 	>=media-libs/vigra-1.4
-	>=app-text/poppler-0.12.3-r3[xpdf-headers]"
+	media-libs/libpng
+	>=sys-libs/db-4.3
+	virtual/jpeg
+	>=x11-libs/cairo-1.0.2
+	x11-libs/libXaw
+	x11-libs/libXinerama
+	x11-libs/libXrandr"
 
 RDEPEND="java? ( >=virtual/jre-1.5 )
 	${SPELL_DIRS_DEPEND}
 	${COMMON_DEPEND}"
 
 DEPEND="${COMMON_DEPEND}
-	x11-libs/libXrender
-	x11-libs/libXtst
-	x11-proto/printproto
-	x11-proto/xextproto
-	x11-proto/xproto
-	x11-proto/xineramaproto
-	>=sys-apps/findutils-4.1.20-r1
-	dev-perl/Archive-Zip
-	dev-util/pkgconfig
-	dev-util/intltool
+	java? ( || ( =virtual/jdk-1.6* =virtual/jdk-1.5* )
+		>=dev-java/ant-core-1.7 )
 	>=dev-libs/boost-1.36
-	sys-devel/flex
-	sys-devel/bison
-	dev-libs/libxslt
 	>=dev-libs/libxml2-2.0
+	dev-perl/Archive-Zip
+	dev-libs/libxslt
+	dev-util/cppunit
 	>=dev-util/gperf-3
+	dev-util/intltool
+	dev-util/pkgconfig
 	>=net-misc/curl-7.12
-	sys-libs/zlib
+	>=sys-apps/findutils-4.1.20-r1
+	sys-devel/bison
 	sys-apps/coreutils
-	dev-util/cppunit
-	java? ( || ( =virtual/jdk-1.6* =virtual/jdk-1.5* )
-		>=dev-java/ant-core-1.7 )
-	ldap? ( net-nds/openldap )"
+	sys-devel/flex
+	sys-libs/zlib
+	x11-libs/libXrender
+	x11-libs/libXtst
+	x11-proto/printproto
+	x11-proto/xextproto
+	x11-proto/xineramaproto
+	x11-proto/xproto"
 
 pkg_setup() {
 
@@ -213,14 +212,17 @@ src_unpack() {
 
 src_prepare() {
 
+	if use custom-cflags; then
+		ewarn " You are using custom CFLAGS, which is NOT supported and can cause "
+		ewarn " all sorts of build and runtime errors. "
+		ewarn
+		ewarn " Before reporting a bug, please make sure you rebuild and try with "
+		ewarn " basic CFLAGS, otherwise the bug will not be accepted. "
+		ewarn
+	fi
+
 	ewarn
-	ewarn " It is important to note that LibreOffice is a very fragile  "
-	ewarn " build when it comes to CFLAGS.  A number of flags have already "
-	ewarn " been filtered out.  If you experience difficulty merging this  "
-	ewarn " package and use aggressive CFLAGS, lower the CFLAGS and try to  "
-	ewarn " merge again. "
-	ewarn
-	ewarn " Also if you experience a build break, please make sure to retry "
+	ewarn " If you experience a build break, please make sure to retry "
 	ewarn " with MAKEOPTS="-j1" before filing a bug. "
 	ewarn
 
@@ -255,15 +257,6 @@ src_prepare() {
 		ewarn
 	fi
 
-	if is-flagq -ffast-math ; then
-		eerror " You are using -ffast-math, which is known to cause problems. "
-		eerror " Please remove it from your CFLAGS, using this globally causes "
-		eerror " all sorts of problems. "
-		eerror " After that you will also have to - at least - rebuild python otherwise "
-		eerror " the LibreOffice build will break. "
-		die
-	fi
-
 	# Some fixes for our patchset
 	epatch "${FILESDIR}/gentoo-${PV}.diff"
 	epatch "${FILESDIR}/gentoo-pythonpath.diff"
@@ -342,14 +335,18 @@ src_configure() {
 	# Use multiprocessing by default now, it gets tested by upstream
 	export JOBS=$(echo "${MAKEOPTS}" | sed -e "s/.*-j\([0-9]\+\).*/\1/")
 
-	# Compile problems with these ...
-	filter-flags "-funroll-loops"
-	filter-flags "-fprefetch-loop-arrays"
-	filter-flags "-fno-default-inline"
-	filter-flags "-ftracer"
-	filter-flags "-fforce-addr"
+	# set allowed flags for libreoffice
+	# we really should allow '-g' others to build with debugging flags
+	# still need a better check for disk size for that though
+	ALLOWED_FLAGS="-pipe -mcpu -march -mtune"
+	ALLOWED_FLAGS+=" -fstack-protector -fstack-protector-all"
+	ALLOWED_FLAGS+=" -fbounds-checking -fomit-frame-pointer"
+	ALLOWED_FLAGS+=" -W* -w"
 
-	filter-flags "-O[s2-9]"
+	# compiler flags
+	use custom-cflags || strip-flags
+	filter-flags "-O*"
+	append-flags "-w"
 
 	if [[ $(gcc-major-version) -lt 4 ]]; then
 		filter-flags "-fstack-protector"
@@ -362,8 +359,8 @@ src_configure() {
 	use debug || export LINKFLAGSOPTIMIZE="${LDFLAGS}"
 
 	# Make sure gnome-users get gtk-support
-	local GTKFLAG="--disable-gtk --disable-cairo --without-system-cairo"
-	{ use gtk || use gnome; } && GTKFLAG="--enable-gtk --enable-cairo --with-system-cairo"
+	local GTKFLAG="--disable-gtk"
+	{ use gtk || use gnome; } && GTKFLAG="--enable-gtk"
 
 	cd "${S}"
 	./configure --with-distro="Gentoo" \
@@ -379,6 +376,8 @@ src_configure() {
 		--without-git \
 		--with-split \
 		${GTKFLAG} \
+		--enable-cairo \
+		--with-system-cairo \
 		--disable-mono \
 		--disable-kde \
 		$(use_enable kde kde4) \